Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: use SVG image for the resize fit property example #3735

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Docs: use SVG image for the resize fit property example #3735

merged 1 commit into from
Jul 21, 2023

Conversation

kleisauke
Copy link
Contributor

The placeholder image was based on this image, which is licensed under the Pixabay License.

Screenshot:
Screenshot_2023-07-21_171853

@kleisauke kleisauke mentioned this pull request Jul 21, 2023
Closed
@lovell lovell merged commit f908987 into lovell:main Jul 21, 2023
16 of 17 checks passed
@lovell
Copy link
Owner

lovell commented Jul 21, 2023

Great, thanks Kleis.

@kleisauke kleisauke deleted the docs-use-svg-fit-prop branch July 22, 2023 09:40
@kleisauke
Copy link
Contributor Author

Ah, I just noticed that this doesn't blend well with the dark mode (which is automatically utilized based on the prefers-color-scheme media feature). That's probably why the previous image had an opaque background and #ED1C24 as the text color.

@lovell
Copy link
Owner

lovell commented Jul 25, 2023

Good spot, I've added a background via commit 9a66e25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleisauke @lovell